Integration test edge cases #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camille-bouvy-frequenz
force-pushed
the
integration-test-edge-cases
branch
from
349e30b to
5abdcd6
Compare
nhatcher-frequenz
requested changes
Dec 2, 2024
nhatcher-frequenz
left a comment
nhatcher-frequenz
left a comment
There was a problem hiding this comment.
Hi @camille-bouvy-frequenz , a couple of minor comments. But LGTM!
Signed-off-by: camille-bouvy-frequenz <[email protected]>
… allowed bounds Signed-off-by: camille-bouvy-frequenz <[email protected]>
Contributor
Author
|
I now also added validation rules for the quantity and price to be within the bounds from EPEX. The rule about the quantity having to be >= 0.1 MW thus overwrites the rule for positive quantity. I kept both for clarity for now but I could also remove the first rule as it is redundant. |
camille-bouvy-frequenz
force-pushed
the
integration-test-edge-cases
branch
from
5abdcd6 to
d3ea5b9
Compare
Signed-off-by: camille-bouvy-frequenz <[email protected]>
Signed-off-by: camille-bouvy-frequenz <[email protected]>
camille-bouvy-frequenz
force-pushed
the
integration-test-edge-cases
branch
from
d3ea5b9 to
5a2b70d
Compare
camille-bouvy-frequenz
merged commit 5b95dd9
into
frequenz-floss:v0.x.x
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #68.
It also adds a validation rule in the client for the quantity, ensuring that it is always > 0MW.
More edge cases should still be added, so please suggest some scenarios that you think should still be tested!:)